Skip to content
Sign in

Changes

Started 6 mo 0 days ago
Took 59 min on macOS-Intel

Summary

  1. CHG: Matlab > Python: "processdata.py" supports selecting layer in 3D model. However, "depthaverage" is not supported. (commit: 0a57bf8) (details)
  2. CHG: add plot_landsat.py for drawing background RGB image with Landsat dataset. (commit: a0aa6a3) (details)
  3. CHG: plotmodel.py - Fix colorbar option. Use colobar=None, not "None", that the string type does not work in ImageGrid. (commit: b4fa6fc) (details)
  4. CHG: applyoptions.py - Fix "box" option, not using "eval" function. (commit: 480f4c3) (details)
  5. configure.ac: internalise CoDiPack/MediPack flags for --enable-ad (commit: 5573a54) (details)
  6. CHG: Python in plotmodel - Fix showing log scale in colorbar. (commit: b40dae0) (details)
  7. CHG: plot_landsat.py - Fix masking. (commit: 7518f1b) (details)
  8. m4/issm_options.m4: new ISSM_ENABLE_AD macro (–enable-ad support) (commit: 76d01cc) (details)
Commit 0a57bf81382c3695eb8ab9bb8265044a164281de by inwoo
CHG: Matlab > Python: "processdata.py" supports selecting layer in 3D model. However, "depthaverage" is not supported.
 (commit: 0a57bf8)
The file was modifiedsrc/m/plot/processdata.py (diff)
Commit a0aa6a31ab31aecf0f363dadb8ca9a86754cd47a by inwoo
CHG: add plot_landsat.py for drawing background RGB image with Landsat dataset.
 (commit: a0aa6a3)
The file was addedsrc/m/plot/plot_landsat.py
The file was modifiedsrc/m/plot/plot_manager.py (diff)
Commit b4fa6fca4e0c7655ca8d5bf4861f45a154de336a by inwoo
CHG: plotmodel.py - Fix colorbar option. Use colobar=None, not "None", that the string type does not work in ImageGrid.
 (commit: b4fa6fc)
The file was modifiedsrc/m/plot/plotmodel.py (diff)
Commit 480f4c39eaaeca66cdaa6f44576a58a25e554f10 by inwoo
CHG: applyoptions.py - Fix "box" option, not using "eval" function.
 (commit: 480f4c3)
The file was modifiedsrc/m/plot/applyoptions.py (diff)
Commit 5573a54cc120d2d6e3117a037f0aebc9b9e60cec by justinkinjun.hew
configure.ac: internalise CoDiPack/MediPack flags for --enable-ad

* Adds --enable-ad plus --with-{codi,medi}pack-dir options.
* When --enable-ad is chosen:
    - Defines ISSM_USE_AD for conditional compilation.
    - Injects include paths, library paths and –lcodi/–lmedi into
      AM_CPPFLAGS, AM_LDFLAGS and LIBS so every sub-dir picks them up.
    - Automatically disables PETSc to avoid an impossible combo.
* Emits AM_CONDITIONAL(USE_AD) for any Makefile.am that still wants it.
* Leaves all Makefile.am files untouched; the Spack recipe no longer
  needs setup_build_environment() hacks.

Doing this upstream means:
  • Classic builds behave exactly as before.
  • AD builds work out-of-the-box for Spack, EasyBuild or manual
    ./configure invocations.

style changes and revert

issm options repetition removed
 (commit: 5573a54)
The file was modifiedconfigure.ac (diff)
Commit b40dae068687da5ae207916ab0acc145dbf1b422 by inwoo
CHG: Python in plotmodel - Fix showing log scale in colorbar.
 (commit: b40dae0)
The file was modifiedsrc/m/plot/applyoptions.py (diff)
The file was modifiedsrc/m/plot/processdata.py (diff)
Commit 7518f1b8a98bc526d27c3ee232ece1f738ac58c9 by inwoo
CHG: plot_landsat.py - Fix masking.
 (commit: 7518f1b)
The file was modifiedsrc/m/plot/plot_landsat.py (diff)
Commit 76d01cc48be97dcda3f77f4c6d030fb7cadfe38c by justinkinjun.hew
m4/issm_options.m4: new ISSM_ENABLE_AD macro (–enable-ad support)

* Adds ISSM_ENABLE_AD to handle --enable-ad plus --with-{codi,medi}pack-dir.
* Macro embeds CoDiPack/MediPack include-dirs, lib-dirs and -lcodi/-lmedi
  into AM_CPPFLAGS, AM_LDFLAGS, LIBS so no Makefile.am edits are needed.
* Automatically drops PETSc when AD is on, defines ISSM_USE_AD, and exposes
  AM_CONDITIONAL(USE_AD).
* configure.ac now simply calls ISSM_ENABLE_AD after ISSM_OPTIONS.

Moves all AD logic out of configure.ac and keeps option handling in the
shared macro library.

added enable AD into configure.ac
 (commit: 76d01cc)
The file was modifiedconfigure.ac (diff)
The file was modifiedm4/issm_options.m4 (diff)